Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dot option #148

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Document dot option #148

merged 5 commits into from
Oct 9, 2022

Conversation

mrienstra
Copy link
Contributor

Resolves #38 (comment)

If the bit about:

This option is passed through to glob.

... Isn't accurate, happy to remove that part. That was my best guess after poking around the deps and checking https://npmgraph.js.org/?q=del.

Resolves sindresorhus#38 (comment)

If the bit about:
>This option is passed through to [`glob`](https://github.com/isaacs/node-glob#dots).
... Isn't accurate, happy to remove that part. That was my best guess after poking around the deps and checking https://npmgraph.js.org/?q=del.
@mrienstra
Copy link
Contributor Author

mrienstra commented Sep 20, 2022

Thinking about it more, it should probably a bit more clear, as the actual difference with { dot: true } is that * matches dot files, not so much that dot files are deleted.

I'll make an edit later.

Edit: done.

... Tempting to throw in "hidden" and / or "period" somewhere, to make it even easier to find, but that's probably not necessary.

readme.md Outdated Show resolved Hide resolved
Based heavily on https://github.com/mrmlnc/fast-glob#dot

Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@mrienstra mrienstra requested a review from sindresorhus October 6, 2022 03:08
@sindresorhus sindresorhus merged commit 9e17de8 into sindresorhus:main Oct 9, 2022
@mrienstra mrienstra deleted the patch-1 branch October 9, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why hidden files are not deleted ?
2 participants